MCUpdater / MCU-API

API-level code for MCUpdater
Apache License 2.0
1 stars 6 forks source link

Override mod not getting updates (hyper-aggressive cache) #12

Closed allaryin closed 6 years ago

allaryin commented 6 years ago

I have a mod that is being imported from another XML and then overridden in the local pack. This works fine until the override itself needs to be updated. MCU does not download the new file.

allaryin commented 6 years ago

Original pack: https://github.com/allaryin/pack-continuum/blob/master/ServerPack.xml#L559-L565

Update that isn't catching the change: https://github.com/allaryin/pack-continuum/blob/update-0614/ServerPack.xml#L559-L565

allaryin commented 6 years ago
[23:55:16.682] Downloading: CodeChicken Lib
[23:55:16.682] mods/codechickenlib.jar - Started
[23:55:16.686] mods/codechickenlib.jar - Hash matches - No download
allaryin commented 6 years ago

Confirmed that if I rename the old file and hit update again, it still doesn't fetch the correct new file:

$ md5sum codechickenlib*
b92d9acf18144067cd3143116808c32f codechickenlib.jar
b92d9acf18144067cd3143116808c32f codechickenlib.jar.old

(Checksum should be 7c06a1ef2895b896487de16a9e61b597, the one shown is the previous hash).

allaryin commented 6 years ago

The issue is one of documentation. The "Override" ModType does not support these attributes - overriding the sort of stuff I'm trying to requires use of the Regular type instead.