MCarlomagno / FaceRecognitionAuth

😀🤳 Simple face recognition authentication (Sign up + Sign in) written in Flutter using Tensorflow Lite and Firebase ML vision library.
BSD 3-Clause "New" or "Revised" License
389 stars 194 forks source link

update null safety and fixed minor bug #44

Closed Always-Bijoy closed 2 years ago

Always-Bijoy commented 2 years ago

I have fixed null safety issues in sign up page and fix some minor bugs

Always-Bijoy commented 2 years ago

hello sir, I am really new to collaboration. If wrong, please forgive me. I have solved issues that create "null check operator use null value", from the sign-up page remove null from 181 no line face: faceDetected!, imageSize: imageSize!), after that face isn't found then I have to change in sign-up page before 102 no line and add setState(() { faceDetected = _faceDetectorService.faces[0]; }); for insert faceDetected data. also need to remove this line await _cameraService.cameraController?.stopImageStream(); otherwise its causing error

Then in database helper class need to remove this line if (_database != null) return _database; cause it's causing some kind of error

and in auth action button need to modify this line this._mlService.setPredictedData([]); remove null, then its work. Hope there would be no issues. Thank you.

On Tue, May 31, 2022 at 12:46 AM Marcos Carlomagno @.***> wrote:

@.**** commented on this pull request.

Hi! thanks a lot for collaborating, could you specify better the bug and the changes you've made for fixing it?

— Reply to this email directly, view it on GitHub https://github.com/MCarlomagno/FaceRecognitionAuth/pull/44#pullrequestreview-989623305, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG7E323EH7U3S3YYRYQG53TVMUEJNANCNFSM5XGBY2XA . You are receiving this because you authored the thread.Message ID: @.***>