Why does it generate a hollow fake terrain above the existing terrain? how can i fix it?

[VolcanoBoy5]

Issue tracker rule checks (read carefully)

• [X] I have checked that my problem is not already reported
• [X] I have checked that my problem is not covered on Knowledge Base or on MCreator's Wiki
• [X] I have made sure this bug is not plugin-related (tested with MCreator without plugins installed)
• [X] I have checked that my written content does not violate the publishing guidelines

Issue description

Hello, I noticed recently (not before) that my generated world (in custom dimension) is full of hollow craters and hollow hills, if I look below it is generated above the existing flat terrain. Can I fix this somehow within MCreator? it really spoils my modding experience that such errors occur in my mod,

I am attaching a video about things and the settings of one of the biom generations. (It is the same for all of them, except for humidity and temperature.)

https://imgur.com/hDfH59b

https://imgur.com/yMPxL1Z

https://imgur.com/p4sQWMQ

How to reproduce this issue?

Step 1: Generate a Minecraft World Step 2: Travel Custom dimension Step 3: Look the terrain

Operating system

Windows

Details

Mcreator 2024.2 Forge 1.20.1

Example workspace

No response

Logs

No response

[KlemenDEV]

Please attach minimal demo workspace (not your whole workspace) with one dimension showcasing the issue, so we can use that for testing

[VolcanoBoy5]

@KlemenDEV https://www.mediafire.com/file/91fl4xj0z0w69pb/test.zip/file

Here is the Workspace download link, unfortunately this was the only way I could attach it, because the size of the ZIP is 74 MB, I hope it will be good this way. Anyway, what could be wrong in the generation?

Please attach minimal demo workspace (not your whole workspace) with one dimension showcasing the issue, so we can use that for testing

[KlemenDEV]

I have asked for minimal demo workspace, are you sure minimal example is 74MB? How many mod elements it contains?

Make sure to export it using File -> Export to ZIP (without run dir)

[VolcanoBoy5]

@KlemenDEV test.zip

Here is the demo project file, I suffered a lot to make it less than 25 megabytes. I hope it will work. Did you ask for this?

[KlemenDEV]

This is ok, but the realty is you should

Make sure to export it using File -> Export to ZIP (without run dir)

[VolcanoBoy5]

This is ok, but the realty is you should

Make sure to export it using File -> Export to ZIP (without run dir)

then would you look into it, please, what could be the problem with the terrain? Thank You <3 I love the Mcreator

[KlemenDEV]

We will look into it as soon as someone from triage gets time :)

[VolcanoBoy5]

We will look into it as soon as someone from triage gets time :)

Okay, thank you very much <3

[KlemenDEV]

I am unable to reproduce this making new world in your demo workspace

[VolcanoBoy5]

I am unable to reproduce this making new world in your demo workspace

if you go a little further from the spawn point/portal, you can see such craters and bulges that are hollow underneath.

[VolcanoBoy5]

I am unable to reproduce this making new world in your demo workspace

https://github.com/user-attachments/assets/35cc1a13-e4db-4b58-ac25-f99925f2dedc

This is an example with my problem, (this bug is probably not true for all hills, but only for one of them, if you look more carefully around the world you can notice it.)

[KlemenDEV]

The example in your video is normal, it is a carved cave. Keep in mind you set fluid block to air, which may confuse the carver a bit and also will leave all caves dry

[KlemenDEV]

Could you provide world seed and coordinates for further investigation?

[KlemenDEV]

Seems vanilla surface rule can not 100% guarantee that no cave will get surface:

[VolcanoBoy5]

Could you provide world seed and coordinates for further investigation?

The Seed: -240003963885227891 And the coord: X: -160 Y: 49 Z: -100 if I typed it wrong, I will correct it in my reply.

[VolcanoBoy5]

Seems vanilla surface rule can not 100% guarantee that no cave will get surface:

really? I didn't know that, the water is turned off because the custom dimension would generate big fake seas, I don't want that.

[VolcanoBoy5]

The example in your video is normal, it is a carved cave. Keep in mind you set fluid block to air, which may confuse the carver a bit and also will leave all caves dry

actually, if it is really because the water is off and there is air instead, there should be an option to turn it off: Expample: Water/Carved Caves Off (for example, when setting the biome default feature.

[KlemenDEV]

Carvers are per-dimension, not per biome.

For water, I was only speculating, although I can imagine fluid deposits being placed underwater. You can specify stone for underwater block to improve this to a degree. Then the "surface" under air "fluid" will also be stone, not the surface block

[VolcanoBoy5]

Carvers are per-dimension, not per biome.

For water, I was only speculating, although I can imagine fluid deposits being placed underwater. You can specify stone for underwater block to improve this to a degree. Then the "surface" under air "fluid" will also be stone, not the surface block

is there a way that if I set water in the biome, it can be turned off so that large lakes/seas are generated?

[KlemenDEV]

Maybe with custom code or even custom carvers for lakes

[VolcanoBoy5]

Carvers are per-dimension, not per biome.

For water, I was only speculating, although I can imagine fluid deposits being placed underwater. You can specify stone for underwater block to improve this to a degree. Then the "surface" under air "fluid" will also be stone, not the surface block

yes i think i will use this solution, just some parts of the world will be a bit flat.

[VolcanoBoy5]

Maybe with custom code or even custom carvers for lakes

is there any solution to reduce the size of the lakes/seas, in custom dimensions? I would like it to have some water in it, but not this big, but only a lake the size of a few blocks

[KlemenDEV]

Probably with JSOn changes. I would advise checking out https://minecraft.fandom.com/wiki/Custom_world_generation and related guides and documentation and then locking code of selected mod element and doing manual changes.

You can also ask on our forums, although I am not sure there are many experts on the website around this

[github-actions[bot]]

:wave: @VolcanoBoy5, we use GitHub issue tracker exclusively for bug reports. However, this issue appears to be a support or a feature request. Use our Forums on the website for support and feature requests.