MD-Anderson-Bioinformatics / NG-CHM

A dynamic, graphical environment for exploration of clustered or non-clustered heat map data in a web browser.
https://bioinformatics.mdanderson.org/main/NG-CHM-V2:Overview
GNU General Public License v2.0
10 stars 9 forks source link

Viewer: Issues with drawing of border and selection box of summary screen in generated PDF. #150

Closed jmelott closed 1 year ago

jmelott commented 3 years ago

Originally Pivotal Tracker issue: https://www.pivotaltracker.com/story/show/165470527 bug entered by James M. Melott on 04/19/2019

Tested on map tcga_rppa_brca_v2.0_protein_sample Modified the following map preferences for both rows and columns: Summary Display Width: 10% Dendrogram Height: 50% Maximum Label Length: 30 characters

Generate PDF with default settings. Issues: Horizontal portions of selection box not drawn correctly. Dark bars drawn on left and right sides of summary PDF. See attached PDF for example output displaying issue.

tcga_rppa_brca_v2.0_protein_sample (20).pdf

jmelott commented 3 years ago

@markstucky - May 14 2019, 3:36 pm I'm not sure users are going to tweak their viewer display to this extent prior to viewing a heat map in PDF. Especially if the view in the viewer itself doesn't even look good. PDFs are drawn from the canvases displayed in the viewer BUT are scaled. generally upward, to fill the PDF page. To see the best PDF the summary view window should be near 50%. This is the way PDF has been designed to work so a full redesign would likely be required to make this particular test case look good in a PDF.

We could change the PDF logic to not fill the page but that would be a departure from the way it is working now. We should talk about this one.

jmelott commented 2 years ago

Still present in version 2.21.2 on 2022 02 11.

jmelott commented 1 year ago

Fixed in v2.23.2 build 4.