search

MD-Anderson-Bioinformatics / NG-CHM

A dynamic, graphical environment for exploration of clustered or non-clustered heat map data in a web browser.
https://bioinformatics.mdanderson.org/main/NG-CHM-V2:Overview
GNU General Public License v2.0
10 stars 9 forks source link

Build args and NG-CHM-Artifacts release #521

Closed marohrdanz closed 11 months ago

marohrdanz commented 11 months ago

This pull request addresses two main concerns:

1. Use build args for git information in Docker

These changes are in the Dockerfile, ant build files, and README

We have been using git information in the ant builds, but doing so in a clumsy way: using exec git in the ant build file, which necessitated passing in the whole .git directory in the Dockerfile.

This pull request changes this to instead pass the git information via build arguments. For example:

docker build \
       --build-arg="GIT_COMMIT=$(git rev-parse --short HEAD)" \
       --build-arg="GIT_LATEST_TAG=$(git describe --tags --abbrev=0)" \
       -t ngchm:latest .

2. Use a GitHub Action Workflow to create NG-CHM-Artifacts release

These changes are in the .github/workflows directory

Added workflow file NG-CHM-Artifacts_release.yml to address issue #514 .

Additionally, I refactored existing actions (including changing the names of the files) for clarity both in reading the files and viewing the actions in the browser.