Address GitHub Actions issues

MD-Anderson-Bioinformatics / NG-CHM

A dynamic, graphical environment for exploration of clustered or non-clustered heat map data in a web browser.

https://bioinformatics.mdanderson.org/main/NG-CHM-V2:Overview

GNU General Public License v2.0

10 stars 9 forks source link

Address GitHub Actions issues #536

Closed marohrdanz closed 3 months ago

marohrdanz commented 3 months ago

This merge request addresses the following issues with GitHub Actions:

NGCHMSupportFiles action failed because of newly added vignette
- Issue: #534
- Resolution: add knitr to GitHub Action workflow to allow vignette to build
NG-CHM-Artifacts actions leave old minified js files in viewer.build/server.app/javascript
- Issue: #528
- Resolution: add a git rm to remove these old files

ChrisWakefield commented 3 months ago

I'm curious about the git rm only targeting certain *.js files. Are there other files that should also be removed?

marohrdanz commented 3 months ago

For the other files, the file name is the same from commit to commit. For example ShaidyMapGen.jar is just overwritten by the new version. But for these .js file, the file names may be different from commit to commit.