MD-Anderson-Bioinformatics / NG-CHM_GUI_BUILDER

Simple graphical builder for Next-Generation Clustered Heat Maps
GNU General Public License v2.0
1 stars 1 forks source link

Randomization of covariates not kept in sync with map during some edits. #63

Open jmelott opened 1 year ago

jmelott commented 1 year ago

To reproduce: Create map with sample map. Click on Advanced Features. Use first row and column of sample matrix as continuous covariates. Click new until on Covariates page Add some additional covariates. Click next until on Format Heat Map page. Switch Format Tasks to Heat Map Display Switch selection color. Watch covariates and map as you click Apply button. Covariates elements change order, but map order does not change. If one changes, so should the other or neither should change.

bmbroom commented 1 year ago

I cannot reproduce. See attached before (green selection color) and after (purple selection color) screen shots.

AfterChangeSelectionColor BeforeAnyChange

jmelott commented 1 year ago

Just verifying since I can't tell from the screenshots, did you click apply? Asking because the change only happens on apply.

jmelott commented 1 year ago

Testing in Chrome Version 112.0.5615.138 (Official Build) (64-bit) on Windows 10.0.19042 Before changing gaps color image

After changing gaps color and clicking apply image

bmbroom commented 1 year ago

Yes, I clicked Apply. I also tried changing Gaps color and clicking Apply. That had no effect either.

bmbroom commented 1 year ago

My original screen shots were with Chrome 112.0.5615.165 on Linux. I also tried Chrome on MacOS and Firefox on Linux. The screen shots from both those were the same as my screen shots above.

I notice both your screen shots differ from mine and from each other.

Bradley

bmbroom commented 1 year ago

Did you miss saying to change row/column ordering to Random in your instructions?

I notice that with that set, the covariate order changes but the map order doesn't when changing the map display.

jmelott commented 1 year ago

It looks like I did. I guess I must thought the "Randomization of covariates" part covered it at the time, but I should have put it in the details too.

jmelott commented 1 year ago

Still present in 2.23.5