search

MD-Anderson-Bioinformatics / NGCHM-R

An R library for creating Next-Generation Clustered Heat Maps (NG-CHM)
http://bioinformatics.mdanderson.org/main/NG-CHM-V2:Overview
7 stars 3 forks source link

Change 'caption' to 'description' #26

Closed marohrdanz closed 1 year ago

marohrdanz commented 2 years ago

With the goal of obtaining uniform language for users and developers, this pull request changes the 'chm.info.caption' property to 'chm.info.description'.

In the NGCHM viewer, when users hover over the 'Map Name' label, this property is displayed with the label 'Description'.

For the code in this PR to work as intended, ShaidyMapGen.jar in the NGCHMSupportFiles must be updated with the code in the NGCHM Viewer pull request: https://github.com/MD-Anderson-Bioinformatics/NG-CHM/pull/100

jmelott commented 2 years ago

Would that break descriptions in all existing maps?

marohrdanz commented 2 years ago

Would that break descriptions in all existing maps?

See https://github.com/MD-Anderson-Bioinformatics/NG-CHM/pull/100

marohrdanz commented 1 year ago

We decided not to do this.