search

MD-Studio / MDStudio

A general framework for microservice based distributed applications
Apache License 2.0
12 stars 0 forks source link

Fix .d.ts errors in primeng #2

Closed pevisscher closed 7 years ago

pevisscher commented 7 years ago

Currenty running gulp serve will yield compilation errors like

/app/app/node_modules/primeng/components/accordion/accordion.d.ts(27,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/accordion/accordion.d.ts(27,28): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/carousel/carousel.d.ts(51,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/carousel/carousel.d.ts(51,30): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/carousel/carousel.d.ts(52,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/carousel/carousel.d.ts(52,33): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/carousel/carousel.d.ts(53,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/carousel/carousel.d.ts(53,24): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/chips/chips.d.ts(32,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/chips/chips.d.ts(32,22): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/datatable/datatable.d.ts(179,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/datatable/datatable.d.ts(179,25): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/dropdown/dropdown.d.ts(50,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/dropdown/dropdown.d.ts(50,19): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/inputtext/inputtext.d.ts(11,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/inputtext/inputtext.d.ts(11,22): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/inputtext/inputtext.d.ts(12,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/inputtext/inputtext.d.ts(12,20): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/inputtextarea/inputtextarea.d.ts(19,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/inputtextarea/inputtextarea.d.ts(19,22): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/inputtextarea/inputtextarea.d.ts(20,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/inputtextarea/inputtextarea.d.ts(20,20): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/lightbox/lightbox.d.ts(34,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/lightbox/lightbox.d.ts(34,25): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/lightbox/lightbox.d.ts(35,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/lightbox/lightbox.d.ts(35,26): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/messages/messages.d.ts(8,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/messages/messages.d.ts(8,18): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/password/password.d.ts(24,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/password/password.d.ts(24,22): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/password/password.d.ts(25,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/password/password.d.ts(25,20): error TS1005: ';' expected.
/app/app/node_modules/primeng/components/tree/tree.d.ts(44,14): error TS1005: '=' expected.
/app/app/node_modules/primeng/components/tree/tree.d.ts(44,24): error TS1005: ';' expected.

Somehow the typedefinition files contain the keyword readonly which I believe are not in the specs.

marcvdijk commented 7 years ago

He Paul,

NPM dependancies and typescript definitions can be a bit of an hurdle to manage. From what I can recall I have been downloading typescript definitions manually at times. I also made a few changes to the priming module to add small features to their UI elements.

We could ship the full npm package library and typescript files with the development version of LIEStudio or at least the packages with custom modifications. What do you think?

pevisscher commented 7 years ago

I think we should discuss next wednesday what would be the best course of action.