search

MDAIceland / WaterSecurity

1 stars 1 forks source link

Cities datasets #26

Closed antosalerno closed 3 years ago

VasLem commented 3 years ago

Nice work! Can you please clean up the notebook a little, before I can accept your merge request? Some mardown text is not in line with the code, also I think there is redundant code. Furthermore, what does geojson do? DO we need it? Maybe we should raise this in tomorrow's meeting if you believe it is useful + I can see that you copy pasted some code from somewhere that they computed US states population, please rename any "state" to "country"

antosalerno commented 3 years ago

I used GeoJson for visualisation purposes. I plotted a map at different stages to see whether the cities included (and excluded) in the datasets were uniformly distributed in the world and if all the countries were represented.

I used 'state' as a synonym in the markdown text not in the code. However, I see that it's not really precise so I will change it back 'country.

Thanks for your comments.