search

MDAIceland / WaterSecurity

1 stars 1 forks source link

Merge unlabeled #41

Closed bajo1207 closed 3 years ago

bajo1207 commented 3 years ago

Closes #37. Has to be rerun after #35 for the data to be correct.

VasLem commented 3 years ago

Given #42 is it possible to change the code to the 2 digits one?

VasLem commented 3 years ago

Also, I have seen that some csvs have their indexes also saved, can you change the code to dg.to_csv(path, index=False)? I don't remember where this was exactly :sweat_smile: Other than that, it is better to transform the python file you used to an ipynb one and add documentation there.

bajo1207 commented 3 years ago

All the other unlabeled datasets uses a three digit code, and i don't think we need the econ dataset (#40), so if it's ok for you let's use the three digit code. (I think your api handles 3 digit codes as well).

The index is set as the country code, so it needs to be saved.