Closed orbeckst closed 2 years ago
Merging #110 (cc78b52) into master (6fcf00e) will decrease coverage by
0.51%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 88.08% 87.56% -0.52%
==========================================
Files 6 5 -1
Lines 856 748 -108
Branches 146 133 -13
==========================================
- Hits 754 655 -99
+ Misses 60 56 -4
+ Partials 42 37 -5
Impacted Files | Coverage Δ | |
---|---|---|
gridData/OpenDX.py | 82.27% <ø> (-0.93%) |
:arrow_down: |
gridData/gOpenMol.py | 86.11% <ø> (-0.38%) |
:arrow_down: |
gridData/mrc.py | 96.77% <ø> (-0.20%) |
:arrow_down: |
gridData/__init__.py | 100.00% <100.00%> (ø) |
|
gridData/core.py | 94.18% <100.00%> (-0.22%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2c72933...cc78b52. Read the comment docs.
Ah didn't see you had requested a review for this too, I'll get to it tomorrow UK time
I don't think that a mrcfile release with the fixed https://github.com/ccpem/mrcfile/issues/35 is already out (the last one is 1.3.0 from Feb 2021 on https://pypi.org/project/mrcfile/) so we should not require a minimum version number (even though I think technically that would be the correct thing to do in order to claim having fixed #50 ).
@IAlibay @richardjgowers I am looking for a rubberstamp here ;-)
Thanks for the reminder, I'll get on it during lunch, I have a partial review which apparently I never submitted 😅
Thanks Irfan!