Closed orbeckst closed 1 year ago
@orbeckst could you merge #126 first so we can use the new deployment action?
sure!
Todo list
✅ 1.0.2 deployed to pypi https://pypi.org/project/GridDataFormats/1.0.2/
✅ I tested locally in macOS 3.10 and 3.12 (pip install GridDataFormats==1.0.2
) and all tests pass.
However, the deployment workflow tested the old 1.0.1 https://github.com/MDAnalysis/GridDataFormats/actions/runs/6599833488/job/17929267034#step:5:384
Run # sleep for 10 seconds to make sure things are refreshing upstream
...
# Install via pipx and run tests
python -m pip install ${PIP_URLS} GridDataFormats
python -m pip install pytest
...
Collecting GridDataFormats
Downloading GridDataFormats-1.0.1-py3-none-any.whl (2.1 MB)
...
I would have expected the workflow to pick up and test the uploaded version, 1.0.2. Maybe the 10s delay wasn't enough?
All done here.
@IAlibay when you have time, maybe look at the part of the new deployment workflow that pulls down the latest version from PyPi and tests it (see comment above) as it does not seem to be guaranteed to be testing the release just uploaded.
All done here.
@IAlibay when you have time, maybe look at the part of the new deployment workflow that pulls down the latest version from PyPi and tests it (see comment above) as it does not seem to be guaranteed to be testing the release just uploaded.
You mean the testpypi bit? Did it not pull down the right version? It's hard to enforce a version match (because we aren't pulling down tags), but I can see what we can do
Just saw your above message - I feel like GitHub isn't sending me all the emails right now..
I'll see if we can do a time check at the very least.
WIth #124 fixed and Py 3.12 supported/tested, I'll cut a quick 1.0.2 release.