search

MDAnalysis / MDAKits

The MDAnalysis Toolkits Registry
https://mdakits.mdanalysis.org
Other
17 stars 25 forks source link

Register Zarrtraj #157

Closed ljwoods2 closed 2 months ago

ljwoods2 commented 2 months ago

Zarrtraj available at

https://github.com/conda-forge/zarrtraj-feedstock https://pypi.org/project/zarrtraj/

orbeckst commented 2 months ago

The "latest" test is failing. I haven't had time to look into it but this should pass first.

ljwoods2 commented 2 months ago

Yes, saw that. This is the ghost in the machine moto duplicate keys with Zarr issue that is driving me insane. I can recreate it locally if I pip install zarrtraj[test] but I can't recreate it if I install the exact same set of dependencies locally via conda since they're resolved in a slightly different way. It only affects a moto AWS server, not an actual AWS bucket.

Edit: tried recreating the issue in a script in an environment the test fails in and could not recreate it. I'm convinced this only occurs within pytest but I have no idea why. Set the tests to skip for now since this doesn't significantly affect test coverage and it won't affect users

I'll do another release and once conda forge gets updated these tests will pass

ljwoods2 commented 2 months ago

@orbeckst ready for review, whenever you get a chance