search

MDAnalysis / UserGuide

User Guide for MDAnalysis
https://userguide.mdanalysis.org
22 stars 31 forks source link

refactor: harmonize bash scripts #280

Closed jandom closed 11 months ago

jandom commented 12 months ago

Make the bash scripts consistent in terms of error handling

lilyminium commented 12 months ago

Thanks @jandom, these all look like good improvements and it's failing as it should. I think that deploy_docs_via_travis.sh is actually redundant and should be deleted now -- we moved on from Travis a while ago and at least in the user guide no longer use it for CI or deployment.

I'd hold off on approving/merging until #275 is done so we can check that it also succeeds when there's no error.

jandom commented 12 months ago

Thanks @lilyminium , removed the travis deploy script now – thanks for the pre-review!

jandom commented 12 months ago

@lilyminium PTAL this should be ready to go now, not blocked by anything