search

MDAnalysis / UserGuide

User Guide for MDAnalysis
https://userguide.mdanalysis.org
22 stars 33 forks source link

refactor: remove dead code #289

Closed jandom closed 1 year ago

jandom commented 1 year ago

snapshot tests in the other PR identified dead code that's never executed, we can safely removed it. The snapshot tests ran all the script code, so there is no risk of missing a code-path. Removing this code will make the code simpler to reason about, and make refactoring easier.

jandom commented 1 year ago

Good shout, yeah I switched to using f-strings here and rebased onto master. Will merge after the tests pass