Closed jandom closed 10 months ago
@orbeckst bump
This has gone a bit stale, and I don't want to continue working on this. I'm going to close – feel free to re-open/re-assign if there are any volunteers. Long-term open PRs are pretty bad in my book, they obstruct visibility from what's really needed.
Sorry about that, I didn't see any blocking reviews - I assumed this was just go to go as-is?
Unfortunately I believe pretty much everything here is on me. I don't have time to spend time writing everything at this point though.
I parsed this as pretty blocking, no? Did you mean that it's passable but will need a further touch-up from you?
Did you mean that it's passable but will need a further touch-up from you?
Yes, my point was "the details are all on me", which is what I meant regarding placeholders. Generally the view we take is that if we don't leave a blocking review then it's not blocking.
Gotcha, okay then let's resume – I've restored the branch
Rebased the branch onto develop
to get this green again
Many thanks @IAlibay and @lilyminium – thankful to have this merged 🏆
please suggest changes to the actual text/copy, I just wrote down 1-2 quick sentences