search

MDAnalysis / UserGuide

User Guide for MDAnalysis
https://userguide.mdanalysis.org
22 stars 35 forks source link

nbval errors on stderr output changes #357

Closed IAlibay closed 10 months ago

IAlibay commented 10 months ago

See: #356

FAILED polymer.ipynb::Cell 1 FAILED clustering_ensemble_similarity.ipynb::Cell 3 FAILED clustering_ensemble_similarity.ipynb::Cell 11 FAILED clustering_ensemble_similarity.ipynb::Cell 15 FAILED clustering_ensemble_similarity.ipynb::Cell 18 FAILED convergence.ipynb::Cell 2 FAILED convergence.ipynb::Cell 8 FAILED dimension_reduction_ensemble_similarity.ipynb::Cell 3 FAILED dimension_reduction_ensemble_similarity.ipynb::Cell 10 FAILED dimension_reduction_ensemble_similarity.ipynb::Cell 20 FAILED harmonic_ensemble_similarity.ipynb::Cell 3

IAlibay commented 10 months ago

Do we actually need to do a stderr check here? Could we just skip it completely?

lilyminium commented 10 months ago

Makes sense to me!

IAlibay commented 10 months ago

Very quick attempt at doing this in https://github.com/MDAnalysis/UserGuide/actions/runs/7388882737/job/20100603113?pr=358 doesn't seem to work. Someone might be better suited to take over here.