search

MDAnalysis / cellgrid

MIT License
7 stars 6 forks source link

cellgrid_distance_array correctly formatted? #6

Open backpropper opened 8 years ago

backpropper commented 8 years ago

I was trying to use the cellgrid_distance_array function from the capped_distance.py file. In line no. 49, you check for both groups being equal. Is it correct or should we check if their dimensions are correct? If yes, should I issue a PR?

richardjgowers commented 8 years ago

https://github.com/richardjgowers/cellgrid/blob/master/cellgrid/core.pyx#L240

The == operation calls __eq__ on the objects. I've made this check the dimensions, so two CellGrids are equal if their dimensions are correct.