search

MDAnalysis / cellgrid

MIT License
7 stars 6 forks source link

added float32 and float64 compatibility #7

Closed kash1102 closed 7 years ago

kash1102 commented 7 years ago

@richardjgowers could you please guide me regarding the errors I could not figure out my mistake since I only made changes to 3 files core.pyx , cgmath.pyx and capped_distance.py . Thanks :)

richardjgowers commented 7 years ago

@kash1102 looks like a problem with travis rather than this fix. You'll need to change the existing tests so they test both precisions we support

kash1102 commented 7 years ago

@richardjgowers I have changed the test files to test both precisions kindly look the changes once. any inputs on the changes will be highly appreciated.

Thanks :)

orbeckst commented 7 years ago

Do you know why the tests failed?

richardjgowers commented 7 years ago

Ok I fixed the tests on the master branch, can you rebase onto it and force push to this PR? (git fetch and update your version of master, git rebase master from this branch, then git push -f to this PR)