search

MDAnalysis / cookiecutter-mdakit

Cookiecutter for Python packages based on MDAnalysis
MIT License
7 stars 5 forks source link

Revert test matrix back to manual #111

Closed lilyminium closed 5 months ago

lilyminium commented 7 months ago

Relates to #110

Changes made in this Pull Request:

PR Checklist

lilyminium commented 7 months ago

Annoyingly, I had to add a line allowing coverage failures due to the current issues -- perhaps this can be taken out if/when those get resolved.

lilyminium commented 7 months ago

@IAlibay this is ready for review if you have a chance to have a look! I verified that tests failed before pushing the fix, and tests seem to be passing now that the coverage step is allowed to fail. Apologies it took longer than expected.

lilyminium commented 5 months ago

Ok, I've set up a CODECOV token for the https://github.com/MDAnalysis/mdakit-cookie repository and upgrading the act action appears to get CI working again. I've also added some comments to set fail_ci_if_error: false for downstream kits that may need it for forks.

Edit: nevermind now CI isn't running for some reason. -_-

lilyminium commented 5 months ago

Unless I'm missing something, the codecov upload action may be forever doomed to failure as it's not a valid GitHub run. The CI now gets around it by on-the-fly editing the CI to accept a failed codecov action.

IAlibay commented 5 months ago

@lilyminium - just had a brief look at the codecov action history, this came up: https://github.com/codecov/codecov-action/pull/1404

I've not had time to test it out (or read up on all the history related to it 😅), but it looks like the latest version of v4 might fix all the problems? Is it worth trying here?

lilyminium commented 5 months ago

Upgrading to codecov v4 kicked off a whole bunch of things (needing to upgrade act, leading to a bunch of issues where the most recent is libmamba failing to install MDAnalysis into the image due to lack of disk space). I think I might do that in a separate PR so we can firstly get Lawson's fix in and not overly complicate this one.

lilyminium commented 5 months ago

Apologies @IAlibay -- as mentioend in a previous comment IMO it might be easier to address the version concerns in a new PR, as this one unblocks #115 slightly it'd be good to get it in!

lilyminium commented 5 months ago

Thanks @IAlibay for all the work you put into reviewing!