MDAnalysis / cookiecutter-mdakit

Cookiecutter for Python packages based on MDAnalysis
MIT License
7 stars 5 forks source link

[WIP] ModuleNotFound Error Fix #115

Closed ljwoods2 closed 4 months ago

ljwoods2 commented 4 months ago

Fixes #113

Changes made in this Pull Request:

I used a repo which contains multiple packages as a model for these changes: https://github.com/Gallopsled/pwntools The idea is that if the repo name differs from the package name, you should be able to do

pip show <repo_name> 

But not be able to import the package using the reponame. You must import using

import <package_name>

However, this leaves the issue of versioning, since the package_name's __init__ method uses (AFAIK) the version is associated with the repo_name. I set the package's version to use the version associated with repo_name by default and the user will have to be responsible for changing this if it doesn't apply (in the case they have two packages in the repo that are both different versions)

PR Checklist

pep8speaks commented 4 months ago

Hello @ljwoods2! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-05-28 01:48:17 UTC
lilyminium commented 4 months ago

Thank you @ljwoods2 for fixing this issue!

orbeckst commented 4 months ago

Many thanks @ljwoods2 and @lilyminium !