MDAnalysis / cookiecutter-mdakit

Cookiecutter for Python packages based on MDAnalysis
MIT License
7 stars 5 forks source link

overhaul CI #26

Closed lilyminium closed 2 years ago

lilyminium commented 2 years ago

Fixes #23 Fixes #16

This PR redoes CI, which now:

Despite ostensibly addressing fairly low-priority issues, this fixes CI so that it actually runs -- turns out the cookie tests weren't actually working as in the main branch. Therefore it's necessary.

Decisions that could do with discussion:

pep8speaks commented 2 years ago

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 14:80: E501 line too long (80 > 79 characters) Line 105:80: E501 line too long (106 > 79 characters)

[Line 4:80](https://github.com/MDAnalysis/cookiecutter-mdakit/blob/88ffc4d58a99e761987e51d4cbba015818763702/{{cookiecutter.repo_name}}/{{cookiecutter.package_name}}/tests/analysis/test_{{cookiecutter.template_analysis_class.lower()}}.py#L4): E501 line too long (140 > 79 characters)

Comment last updated at 2022-08-11 22:59:28 UTC
lilyminium commented 2 years ago

@orbeckst @IAlibay @fiona-naughton your reviews and opinions on the items in the first comment would be highly appreciated, but I do realise that this is a fairly large PR. If one of you is happy with the behaviour I think it adds, and with the examples at https://github.com/MDAnalysis/cookiecutter-mdakit/tree/examples and https://github.com/MDAnalysis/mdakit-cookie branches, then I'll count that as good enough :)

orbeckst commented 2 years ago

I don't know if we have a quota for uploading artifacts. I set the retention time to 3 days (down from the default 90) just in case.

Yes, AFAIK there's a ~500 GB~ 500 MB quota on artifacts (I saw it when I set up the artifact uploading for the whitepaper). Reducing storage duration to 3d is a good idea.

orbeckst commented 2 years ago

I am in favor of putting re-useable actions into separate repos. MIT license is also totally fine with me.

IAlibay commented 2 years ago

I don't know if we have a quota for uploading artifacts. I set the retention time to 3 days (down from the default 90) just in case.

Yes, AFAIK there's a ~500 GB~ 500 MB quota on artifacts (I saw it when I set up the artifact uploading for the whitepaper). Reducing storage duration to 3d is a good idea.

We actually burn through this real quick as an organisation, especially when we do releases (wheels for everything is a good 200 MB being used for a few days). I'd suggest going for the minimum artifact retention period that is useful here (even down to a single day unless you expect to need to inspect / debug artifact contents a lot)

orbeckst commented 2 years ago

FYI, https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions

Product Storage Minutes (per month)
GitHub Free for organizations 500 MB  2,000
orbeckst commented 2 years ago

Maybe storage is actually free for public repositories and the limits only apply to private repos. I am not 100% sure

GitHub Actions usage is free for both public repositories and self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account.

In any case, keeping retention times short is good stewardship of resources.

lilyminium commented 2 years ago

Thanks for looking this over, @IAlibay and @orbeckst! I made #27 as an issue so I can merge this CI now. I'll also keep an eye on the storage quota if the retention time becomes an issue. :)