template CI workflow: do not run codecov coverage in CRON CI

MDAnalysis / cookiecutter-mdakit

Cookiecutter for Python packages based on MDAnalysis

MIT License

7 stars 5 forks source link

template CI workflow: do not run codecov coverage in CRON CI #58

Closed orbeckst closed 1 year ago

orbeckst commented 1 year ago

Fixes #54

Changes made in this Pull Request:

add condition on running codecov to exclude CRON CI

PR Checklist

n/a Tests?
n/a Docs?
[x] CHANGELOG.md updated?
[x] AUTHORS.md updated?
[x] Issue raised/referenced?

orbeckst commented 1 year ago

Have to figure out how to protect && for the templating

FAILED tests/test_output.py::test_write_outputs[n-DependencyType.CONDAFORGE] - jinja2.exceptions.TemplateSyntaxError: unexpected char '&' at 3799

orbeckst commented 1 year ago

Removing the unnecessary expression syntax ${{ ... }} in if: avoided having to worry about to quote ${{ ... }} for the jinja templating.

Still failing, although I don't understand (yet) why.

Also fails due to #56.

orbeckst commented 1 year ago

The error in actions "Error: Job 'main-tests' failed" and looking at the 10,000 lines of output does not reveal to me where the problem is.

@lilyminium @IAlibay @ianmkenney would you mind having a look?

orbeckst commented 1 year ago

Who knows, maybe it's just codecov ... and cycling the PR magically fixes things?

Btw, how are the differently numbered tests "GH Actions CI/main-tests-1", ..., "GH Actions CI/main-tests-12" generated and what do they do — are they different entries in the OS test matrix? I couldn't figure it out by looking at workflows and tests/ and in particular I don't understand what is really failing because each section says "success". There seem to be codecov upload errors (which still count as success) so that's why I am just pushing another silly commit.

lilyminium commented 1 year ago

Sorry for the delay, was pretty swamped with OMSF stuff.

About the numbered tests -- yes sorry, I think you're referring to the cookie matrix of tests failing (since the cookie tests a matrix of settings). I usually comment them out if I have to debug something but it shows up very messily in the act output. I'll have a proper look when I get my laptop back tomorrow (eastern) morning.