MDAnalysis / cookiecutter-mdakit

Cookiecutter for Python packages based on MDAnalysis
MIT License
7 stars 5 forks source link

Add theme #85

Closed lilyminium closed 1 year ago

lilyminium commented 1 year ago

Fixes #84

Changes made in this Pull Request:

PR Checklist

IAlibay commented 1 year ago

Looking through the tests - do any of them actually test builds without MDAnalysis as the base org? I can't seem to find the full matrix anywhere.

lilyminium commented 1 year ago

@IAlibay the tests are Python tests, not options in CI -- the matrix is here: https://github.com/MDAnalysis/cookiecutter-mdakit/blob/2bb32a3eb1610ba82c532f49f36166224a3c7187/tests/test_output.py#L33-L35

I initially verified the options by running the cookiecutter myself but I've added them in as tests now, which was good since the github options actually uncovered another bug.

I'll leave this open for another day or two in case you wanted to look at and comment on it -- I know you're busy, though, so no need to re-review if you don't have the time.

If you did want to re-review, I pushed updates from this PR to mdakit-cookie, e.g.: https://github.com/MDAnalysis/mdakit-cookie/tree/TestMDAKit_with_host_MDAnalysis_condaforge-deps_and_ReadTheDocs with MDA as a host and https://github.com/MDAnalysis/mdakit-cookie/tree/TestMDAKit_with_host_other_condaforge-deps_and_ReadTheDocs . The corresponding docs are at https://mdakit-cookie.readthedocs.io/en/testmdakit_with_host_mdanalysis_condaforge-deps_and_readthedocs/ and https://mdakit-cookie.readthedocs.io/en/testmdakit_with_host_other_condaforge-deps_and_readthedocs/ .

IAlibay commented 1 year ago

Thanks, I'll have a look, might not get to it until tomorrow if it can wait - co-running a lot of NF sessions today.

lilyminium commented 1 year ago

Thanks, yeah no rush at all. On Sep 11, 2023, at 22:28, Irfan Alibay @.***> wrote: Thanks, I'll have a look, might not get to it until tomorrow if it can wait - co-running a lot of NF sessions today.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

pep8speaks commented 1 year ago

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 186:80: E501 line too long (82 > 79 characters)

Line 27:21: E228 missing whitespace around modulo operator Line 104:1: E122 continuation line missing indentation or outdented Line 104:2: E225 missing whitespace around operator Line 104:57: E225 missing whitespace around operator Line 106:1: E122 continuation line missing indentation or outdented Line 106:2: E225 missing whitespace around operator Line 106:10: E225 missing whitespace around operator Line 108:1: E122 continuation line missing indentation or outdented Line 108:2: E225 missing whitespace around operator Line 108:11: E225 missing whitespace around operator Line 111:2: E228 missing whitespace around modulo operator Line 111:58: E225 missing whitespace around operator Line 115:2: E225 missing whitespace around operator Line 115:11: E225 missing whitespace around operator Line 163:80: E501 line too long (97 > 79 characters) Line 173:80: E501 line too long (93 > 79 characters) Line 184:80: E501 line too long (93 > 79 characters)

Comment last updated at 2023-09-21 09:03:23 UTC