search

MDAnalysis / mdanalysis-sphinx-theme

The official MDAnalysis Sphinx documentation theme.
Other
1 stars 1 forks source link

CI deployment not working in all PRs #23

Closed lilyminium closed 1 year ago

lilyminium commented 1 year ago

It may depend on who opens the PR? Example: https://github.com/MDAnalysis/mdanalysis-sphinx-theme/pull/22

IAlibay commented 1 year ago

I think this is expected behaviour? At least from the context provided here it looks like github protecting you from outside authors trying to push to the website by just opening a PR.

Do you really want to be pushing to the website during a PR instead of just doing it on merge?

lilyminium commented 1 year ago

Yeah, the correct answer here may be to just not fail CI if the author isn't allowed. I kept the push because some things do render differently on RTD and not sure how best to preview otherwise. We could keep it as an artifact, maybe.

IAlibay commented 1 year ago

Fixed by #38