fix: array to scalar deprecation warning

MDAnalysis / mdanalysis

MDAnalysis is a Python library to analyze molecular dynamics simulations.

https://mdanalysis.org

Other

1.26k stars 641 forks source link

Closed Rohitthakan closed 1 day ago

Rohitthakan commented 1 month ago

Fixes #4339

Changes made in this Pull Request: This PR fixes the array to scalar deprecation warning

[X] I certify that this contribution is covered by the LGPLv2.1+ license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

pep8speaks commented 1 month ago

Hello @Rohitthakan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 217:80: E501 line too long (123 > 79 characters)

github-actions[bot] commented 1 month ago

Hi @Rohitthakan! Thanks for making this PR. We linted your code and found the following:

Some issues were found with the formatting of your code.	Code Location	Outcome
main package	⚠️ Possible failure
testsuite	✅ Passed

Please have a look at the darker-main-code and darker-test-code steps here for more details: https://github.com/MDAnalysis/mdanalysis/actions/runs/9281691657/job/25538172389

Please note: The black linter is purely informational, you can safely ignore these outcomes if there are no flake8 failures!

orbeckst commented 1 month ago

@RMeli could you please take on the role of PR shepherd? If it becomes to much, please say something and unassign yourself. Thanks!

RMeli commented 1 month ago

@Rohitthakan please also have a look at the tests, they are all failing.

RMeli commented 1 week ago

Hi @Rohitthakan, are you still working/interested in working on this?

RMeli commented 1 day ago

Closing for lack of replies. Please feel free to re-open if you are still working on it and want to move forward.