Expose `MDAnalysis.topology.guessers` and `MDAnalysis.guesser.tables` under `MDAnalysis.topology.core`

MDAnalysis / mdanalysis

MDAnalysis is a Python library to analyze molecular dynamics simulations.

https://mdanalysis.org

Other

1.32k stars 652 forks source link

Expose `MDAnalysis.topology.guessers` and `MDAnalysis.guesser.tables` under `MDAnalysis.topology.core` #4766

Closed IAlibay closed 1 month ago

IAlibay commented 1 month ago

Fixes #4765

Changes made in this Pull Request:

PR Checklist

[x] Tests?
[x] Docs?
CHANGELOG updated? - not needed
[x] Issue raised/referenced?

Developers certificate of origin

[x] I certify that this contribution is covered by the LGPLv2.1+ license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

📚 Documentation preview 📚: https://mdanalysis--4766.org.readthedocs.build/en/4766/

pep8speaks commented 1 month ago

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file testsuite/MDAnalysisTests/topology/test_guessers.py:

Line 211:5: E122 continuation line missing indentation or outdented Line 212:5: E122 continuation line missing indentation or outdented Line 213:5: E122 continuation line missing indentation or outdented

Comment last updated at 2024-10-26 20:38:38 UTC

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.63%. Comparing base (800b4b2) to head (447dff6). Report is 1 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #4766 +/- ## =========================================== + Coverage 93.59% 93.63% +0.04% =========================================== Files 177 189 +12 Lines 21710 22792 +1082 Branches 3052 3052 =========================================== + Hits 20320 21342 +1022 - Misses 943 1003 +60 Partials 447 447 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

IAlibay commented 1 month ago

This should be good to go - the tests repeat stuff we already have, but it was cleaner than to have a bunch of randomly wrapped pytest.warns everywhere.