Closed talagayev closed 1 day ago
Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEPÂ 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.29%. Comparing base (
e776f12
) to head (7d0dc7a
). Report is 5 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
I restarted the failing job. The timeout is a known issue unfortunately.
Fixes #4657
Changes made in this Pull Request:
test_instance_serial_backend
totest_base.py
to check that the function works and the instance is correctCurrently I just create a variable of
BackendSerial
forserial_backend
, which I use inFrameAnalysis(u.trajectory).run
to display that it runs with thebackend=serial_backend
and also then check the correct instance ofserial_backend
I wasn't sure here if I should check the instance of
backend
of therun()
inFrameAnalysis(u.trajectory).run(backend=serial_backend)
, since then I would need to modify the code to get the instance ofbackend
fromrun()
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4773.org.readthedocs.build/en/4773/