MDAnalysis / mdanalysis

MDAnalysis is a Python library to analyze molecular dynamics simulations.
https://mdanalysis.org
Other
1.32k stars 651 forks source link

Addition of `isInstance` test of `BackendSerial` #4773

Closed talagayev closed 1 day ago

talagayev commented 3 weeks ago

Fixes #4657

Changes made in this Pull Request:

Currently I just create a variable of BackendSerial for serial_backend , which I use in FrameAnalysis(u.trajectory).run to display that it runs with the backend=serial_backend and also then check the correct instance of serial_backend

I wasn't sure here if I should check the instance of backend of the run() in FrameAnalysis(u.trajectory).run(backend=serial_backend), since then I would need to modify the code to get the instance of backend from run()

PR Checklist

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4773.org.readthedocs.build/en/4773/

pep8speaks commented 3 weeks ago

Hello @talagayev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-11-13 19:57:25 UTC
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.29%. Comparing base (e776f12) to head (7d0dc7a). Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4773 +/- ## =========================================== - Coverage 93.66% 93.29% -0.38% =========================================== Files 177 189 +12 Lines 21726 22808 +1082 Branches 3052 3055 +3 =========================================== + Hits 20349 21278 +929 - Misses 930 1071 +141 - Partials 447 459 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

RMeli commented 1 day ago

I restarted the failing job. The timeout is a known issue unfortunately.