MDAnalysis / membrane-curvature

MDAnalysis tool to calculate membrane curvature.
https://membrane-curvature.readthedocs.io/
GNU General Public License v3.0
29 stars 6 forks source link

FIx CI #112

Closed IAlibay closed 8 months ago

IAlibay commented 10 months ago

Description

Status

codecov[bot] commented 10 months ago

Codecov Report

Merging #112 (d2cf8d5) into main (0cf4856) will not change coverage. The diff coverage is n/a.

Additional details and impacted files
IAlibay commented 10 months ago

🤦🏽‍♂️ I accidentally pushed the update to versioneer to main rather than this branch.

It's effectively just the outcome of calling versioneer install with 0.29, and would have been included in this PR instead.

I hope this is reasonable? Otherwise I'll try to see if I can remove that commit.

IAlibay commented 10 months ago

I've run out of velocity in trying to fix this for now - there's something breaking both rtd and py3.9, not sure why right now.

pep8speaks commented 10 months ago

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1:1: W391 blank line at end of file

Comment last updated at 2023-12-19 18:32:03 UTC
IAlibay commented 10 months ago

Ok this shoudl be good to go.

IAlibay commented 10 months ago

Thanks for the review @RMeli - looks like we aren't set as maintainers for this repo though :(

Indeed who is meant to maintain this repo is unclear to me - this is a discussion we will need to have with @ojeda-e.

RMeli commented 10 months ago

Always sad to see a grey check. =P Indeed, that is a discussion to be had with @ojeda-e and the GSoC mentors.

IAlibay commented 10 months ago

There's a deeper conversation we need to have about what we (coredevs) actually maintain in the org.

IAlibay commented 8 months ago

We will merge this without defined maintainer review to keep CI green. Thanks @RMeli for reviewing.