Closed ctlee closed 1 week ago
Hello @ctlee! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
membrane_curvature/base.py
:Line 138:65: W291 trailing whitespace
membrane_curvature/tests/test_membrane_curvature.py
:Line 135:77: W291 trailing whitespace Line 136:76: W291 trailing whitespace Line 145:16: W291 trailing whitespace Line 168:80: E501 line too long (99 > 79 characters) Line 173:80: E501 line too long (85 > 79 characters) Line 189:16: W291 trailing whitespace Line 193:31: W291 trailing whitespace Line 225:80: E501 line too long (81 > 79 characters) Line 502:80: E501 line too long (119 > 79 characters) Line 507:80: E501 line too long (119 > 79 characters) Line 513:62: W291 trailing whitespace Line 629:80: E501 line too long (81 > 79 characters) Line 630:80: E501 line too long (91 > 79 characters) Line 631:80: E501 line too long (81 > 79 characters)
@ctlee Apologies for the very late response here - unfortunately membrane curvature doesn't have an active maintainer currently so there haven't been anyone to shephred pull requests.
We will try to get someone to review your code as soon as possible. Pinging @MDAnalysis/coredevs here in case someone might want to take on an initial review to help this process along.
Updating against main
should help get CI working properly here (since we've now merged #112 )
Sounds reasonble @ctlee, I am happy to give my approval on a purely code basis, but from a scientific basis I will have to take your assertions about the correctness of the new implementation relative to the old one on trust. I will tag @ojeda-e as the principal developer as she may have a view here. I will leave my view blocking for now pending waiting for feedback. :)
Following up on this as new versions appear to be released! Folks will get incorrect curvature values if their grid spacing isn't 1. Can verify this issue in the current implementation by comparing with the parametric surface tests added in this PR.
An alternative approach is to add a check that the dx, dy is 1 and to throw an error otherwise. @ojeda-e
@ojeda-e are we happy with this PR as is? I would be happy to go ahead, but thought would check with you?
Description
The calculation of the gradients of the height field should respect the grid spacing. This PR adds support for variable grid spacing. It also adds some tests against parametric surfaces.
fixes #115
Todos
Notable points that this PR has either accomplished or will accomplish.
np.gradient
respect grid spacingQuestions
N/A
Status