search

MDAnalysis / membrane-curvature

MDAnalysis tool to calculate membrane curvature.
https://membrane-curvature.readthedocs.io/
GNU General Public License v3.0
29 stars 6 forks source link

PyPi wheels & sdist contain extra user generated files & breaking tests #123

Closed IAlibay closed 7 months ago

IAlibay commented 7 months ago

The wheels & distribution on pypi include:

These are a) breaking tests if you try to do pytest --pyargs membrane_curvature.tests and also b) adding roughly ~ 1 MB of extra stuff that doesn't need to be there.

IAlibay commented 7 months ago

@ojeda-e I think this might be due to using a non-clean local copy for creating wheel & sdist.

My suggestion here is:

a) To add an OIDC-enabled deployment workflow, e.g. "just push tags and it'll upload automatically" b) Create a new bugfix release with the relevant files removed.

Happy to take this on if it sounds reasonable.

ojeda-e commented 7 months ago

Hi @IAlibay thanks for pointing this out, if you are available to work on this I'd appreciate it. I'll resume work on the repo after Thursday.

IAlibay commented 7 months ago

This is fixed with 1.1.1