MDAnalysis / membrane-curvature

MDAnalysis tool to calculate membrane curvature.
https://membrane-curvature.readthedocs.io/
GNU General Public License v3.0
29 stars 6 forks source link

Possible CI solution [PR #49 target] #51

Closed IAlibay closed 3 years ago

IAlibay commented 3 years ago

Description

As discussed here is my solution (assuming CI doesn't complain) to the CI issues in PR #49

To do

Status

pep8speaks commented 3 years ago

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:1: E722 do not use bare 'except'

Comment last updated at 2021-07-22 17:41:07 UTC
IAlibay commented 3 years ago

Ah yes, the ever so descriptive gh actions error messages: "Error when evaluating 'runs-on' for job 'test'. (Line: 25, Col: 14): Unexpected value ''

Sometimes I wonder if it's possible worse than awk's interpretor....

Apologies for the many commits as I work out what character I'm missing...

codecov[bot] commented 3 years ago

Codecov Report

Merging #51 (3abd2d9) into issue46 (abe6ace) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3abd2d9 differs from pull request most recent head fe65181. Consider uploading reports for the commit fe65181 to get more accurate results

IAlibay commented 3 years ago

hand-defining ubuntu works, now to see what's up with matrix.os...

There we go my bad, forgot to add an os entry to the extra test

IAlibay commented 3 years ago

@ojeda-e please do review & squash-merge when you want. After that #46 will probably be ok to merge.

ojeda-e commented 3 years ago

Thanks for your help @IAlibay. I definitely had missing pieces to solve this puzzle.