MDAnalysis / membrane-curvature

MDAnalysis tool to calculate membrane curvature.
https://membrane-curvature.readthedocs.io/
GNU General Public License v3.0
29 stars 6 forks source link

Warning messages significantly affect performance #86

Closed ojeda-e closed 1 year ago

ojeda-e commented 2 years ago

Unfortunately, the more explicit warning messages introduced in #83 significantly affect the performance of the MembraneCurvature, more particularly in membrane-protein systems, where the messages are overwhelming. While working on #84, I found a dramatic difference between version 0.0.1 (no explicit messages) and 0.0.2 (explicit messages). To note, these messages are popping up more often in membrane-protein messages, which is expected, given the fit trans+rot transformation that put lots of atoms out of boundaries.

Possible solutions are:

ojeda-e commented 1 year ago

Closing this issue as the solution was implemented in #95

For the record, this solution was tested in a system with 2500 frames and ~18900 atoms. Performance with explicit warning messages: 57.38 seconds Performance with WarnOnce: 5.24 seconds.