search

MDAnalysis / panedr

Reads Gromacs EDR file to populate a pandas dataframe
GNU Lesser General Public License v2.1
31 stars 7 forks source link

add CHANGELOG file #44

Closed orbeckst closed 2 years ago

orbeckst commented 2 years ago

With panedr evolving towards a building block for other libraries (namely, MDAnalysis) it becomes more important to document changes.

I'd also strongly suggest to formally adopt semantic versioning.

hmacdope commented 2 years ago

@orbeckst do we want to add versioneer as part of adopting semver?

orbeckst commented 2 years ago

I like it, we use it in our cookiecutter, but I also don't want @BFedder to get bogged down with panedr. I'd say that's a nice-to-have right now and can be left for another day.

hmacdope commented 2 years ago

:+1:

IAlibay commented 2 years ago

Is pbr not sufficiently following semver? Any reason for choosing to remove it over versioneer?

hmacdope commented 2 years ago

I wasn't aware that pbr did all that already my bad.

IAlibay commented 2 years ago

Just quickly glancing at things with my phone - seems to me like the issue here is just to make sure release tags are following semver, not that we need to switch version setting tools?

orbeckst commented 2 years ago

The issue is about having a CHANGELOG file ;-).

My comment was, as you said, just making sure that release tags are consistent with semver, and stating somewhere that this project adheres to semver.

orbeckst commented 2 years ago

And I am not familiar with pbr and had already forgotten that I had seen it somewhere. My bad.

IAlibay commented 2 years ago

Closed via #51