MDAnalysis / panedr

Reads Gromacs EDR file to populate a pandas dataframe
GNU Lesser General Public License v2.1
31 stars 7 forks source link

remove test files from coverage #60

Closed orbeckst closed 2 years ago

orbeckst commented 2 years ago

At the moment, coverage includes the tests in the calculation. That's not particularly helpful and should be changed so that coverage excludes test files.

IAlibay commented 2 years ago

So a couple of months back one of the OpenFE folks convinced me that having coverage for test files is actually a good idea. The main idea being that it tells you when you have stuff in your tests that aren't actually doing anything (like leftover classes or code bits that just aren't getting executed for some reason).

IAlibay commented 2 years ago

I want to say @dwhswenson was the person who convinced me?

dwhswenson commented 2 years ago

Yep, that was me. And I was converted by the main developer of coverage. I think he makes the case clearly and concisely: https://nedbatchelder.com/blog/202008/you_should_include_your_tests_in_coverage.html

orbeckst commented 2 years ago

I have admittedly been looking at the test code as a second class citizen. After reading Ned's post I could become convinced that including the tests in coverage could be useful.

orbeckst commented 2 years ago

closing with "wont fix"