search

MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

modify the names of schedulers #112

Closed VOD555 closed 4 years ago

VOD555 commented 4 years ago

Fixes #102

Changes made in this Pull Request:

PR Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #112 into master will not change coverage. The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   97.81%   97.81%           
=======================================
  Files          11       11           
  Lines         642      642           
  Branches       78       78           
=======================================
  Hits          628      628           
  Misses          8        8           
  Partials        6        6
Impacted Files Coverage Δ
pmda/parallel.py 98.49% <75%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae7b6c1...61f9558. Read the comment docs.

orbeckst commented 4 years ago

Still errors – do the docs build locally?

VOD555 commented 4 years ago

They didn't change the scheduler name on the debugging page https://docs.dask.org/en/latest/debugging.html#use-the-single-threaded-scheduler.

orbeckst commented 4 years ago

Did you test that the new name worked? (Maybe the old one also works...?)

VOD555 commented 4 years ago

Did you test that the new name worked? (Maybe the old one also works...?)

@orbeckst My local tests showed that both the old names and the new names worked.