search

MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

Fix InterRDF_s normalization problem when given density = True #121

Closed VOD555 closed 4 years ago

VOD555 commented 4 years ago

Fixes #120

Changes made in this Pull Request:

PR Checklist

VOD555 commented 4 years ago

Tests for density function failed as described in #122 .

pep8speaks commented 4 years ago

Hello @VOD555! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-07-08 16:39:06 UTC
orbeckst commented 4 years ago

I merged master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #121 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          12       12           
  Lines         775      775           
  Branches       91       91           
=======================================
  Hits          759      759           
  Misses         10       10           
  Partials        6        6
Impacted Files Coverage Δ
pmda/rdf.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e98ebcc...44a6b3f. Read the comment docs.

orbeckst commented 4 years ago

Update the CHANGELOG and fix the PEP8 issues and then this should be good to go. Or do you have any other concerns, @VOD555?