MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

Turn ParallelAnalysisBase into dask custom collection #136

Open yuxuanzhuang opened 4 years ago

yuxuanzhuang commented 4 years ago

Fixes #135

Note the only file changes from #132 is parallel.py You can read https://github.com/yuxuanzhuang/pmda/pull/1/files to get the actual changes.

Changes made in this Pull Request:

PR Checklist

pep8speaks commented 4 years ago

Hello @yuxuanzhuang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 305:80: E501 line too long (80 > 79 characters) Line 306:70: E128 continuation line under-indented for visual indent Line 306:80: E501 line too long (80 > 79 characters)

Line 16:80: E501 line too long (84 > 79 characters) Line 16:84: W504 line break after binary operator Line 58:80: E501 line too long (104 > 79 characters) Line 69:80: E501 line too long (115 > 79 characters)

Comment last updated at 2020-08-20 10:39:58 UTC
orbeckst commented 4 years ago

This PR really depends on PR #132 so we should look at that one first. Then you can rebase this one and it will become much cleaner.