MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

Raise ValueError when blocks>frames in make balance #138

Closed yuxuanzhuang closed 4 years ago

yuxuanzhuang commented 4 years ago

Fixes #137

Changes made in this Pull Request:

PR Checklist

yuxuanzhuang commented 4 years ago

It fails now because of #139

orbeckst commented 4 years ago

Let's fix the mpl error #143 before merging

codecov[bot] commented 4 years ago

Codecov Report

Merging #138 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   97.93%   97.94%           
=======================================
  Files          12       12           
  Lines         775      777    +2     
  Branches       91       92    +1     
=======================================
+ Hits          759      761    +2     
  Misses         10       10           
  Partials        6        6           
Impacted Files Coverage Δ
pmda/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b3b566...569ef08. Read the comment docs.

orbeckst commented 4 years ago

Thank you!