MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

Add test and fix for uneven blocks #141

Closed yuxuanzhuang closed 4 years ago

yuxuanzhuang commented 4 years ago

Fixes #140

Changes made in this Pull Request:

PR Checklist

orbeckst commented 4 years ago

let's fix #143 first to get CI back on track

orbeckst commented 4 years ago

@VOD555 if you have any comments on this PR please review

yuxuanzhuang commented 4 years ago

Looks ok to me. The output did not change for anything that we already had, right?

No, it should do nothing to the output.

codecov[bot] commented 4 years ago

Codecov Report

Merging #141 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          12       12           
  Lines         775      775           
  Branches       91       91           
=======================================
  Hits          759      759           
  Misses         10       10           
  Partials        6        6           
Impacted Files Coverage Δ
pmda/parallel.py 98.50% <ø> (ø)
pmda/contacts.py 96.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fde0088...2e803b1. Read the comment docs.