MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

[CI] switch from Travis CI to GitHub actions #151

Open orbeckst opened 2 years ago

orbeckst commented 2 years ago

Fixes #146

Changes made in this Pull Request:

PR Checklist

orbeckst commented 2 years ago

Various issues

orbeckst commented 2 years ago

We don't provide conda packages for Python 2.7 for 1.1.1. So we can either try to install the pip package for the 2.7 tests or drop 2.7 very quickly... I think it's going to be the latter.

orbeckst commented 2 years ago

@VOD555 can you please figure out why one RDF test is failing

pmda/test/test_rdf_s.py::test_density[False] FAILED                      [ 22%]

This needs to be fixed/figured out so that this PR can progress. Thank you!

orbeckst commented 2 years ago

ping @VOD555 please have a look

VOD555 commented 2 years ago

@orbeckst I found the density option of InterRDF_s in current MDAnalysis and pmda are different, in which density=False in MDA means density=True in pmda. It's necessary to make pmda the same as MDA. Do we need to do this change in this PR or in a new one?

VOD555 commented 2 years ago

It's corresponding to #130

orbeckst commented 2 years ago

Make a new PR, please — let me know when you have it ready to review. Thanks!