Closed orbeckst closed 5 years ago
@mimischi can you please review and check that you're happy with this?
@kain88-de @VOD555 @richardjgowers please check that you're happy with the author ordering.
Merging #77 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 8 8
Lines 431 431
Branches 60 60
=======================================
Hits 417 417
Misses 8 8
Partials 6 6
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aaa478c...d930726. Read the comment docs.
I’m okay with the ordering
On Thu 1. Nov 2018 at 22:16, codecov[bot] notifications@github.com wrote:
Codecov https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=h1 Report
Merging #77 https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=desc into master https://codecov.io/gh/MDAnalysis/pmda/commit/aaa478ccc5095f92a8f1cac9edfa2b6b024da108?src=pr&el=desc will not change coverage. The diff coverage is n/a.
[image: Impacted file tree graph] https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=tree
@@ Coverage Diff @@## master #77 +/- ##
Coverage 96.75% 96.75%
Files 8 8 Lines 431 431 Branches 60 60
Hits 417 417 Misses 8 8 Partials 6 6
Continue to review full report at Codecov https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=continue.
Legend - Click here to learn more https://docs.codecov.io/docs/codecov-delta Δ = absolute
(impact), ø = not affected, ? = missing data Powered by Codecov https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=footer. Last update aaa478c...d930726 https://codecov.io/gh/MDAnalysis/pmda/pull/77?src=pr&el=lastupdated. Read the comment docs https://docs.codecov.io/docs/pull-request-comments . — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MDAnalysis/pmda/pull/77#issuecomment-435190042, or mute the thread https://github.com/notifications/unsubscribe-auth/AEGnVmbinn5d1Hzew6AbgGOtCmAs_fniks5uq2SSgaJpZM4YJO6O .
It's good.
I'm also okay!
Thanks all!
Fixes: @mimischi was not added to AUTHORS and CHANGELOG (PR #64)
Changes made in this Pull Request:
PR Checklist