search

MDAnalysis / pmda

Parallel algorithms for MDAnalysis
https://www.mdanalysis.org/pmda/
Other
31 stars 22 forks source link

vstack vs hstack #88

Closed orbeckst closed 5 years ago

orbeckst commented 5 years ago

Fixes #87

Changes made in this Pull Request:

PR Checklist

orbeckst commented 5 years ago

Only tests so far, I don't have a clear idea how to solve this problem (see #87) and the tests.

orbeckst commented 5 years ago

The branch name is misleading: just using np.hstack() is not the solution.

orbeckst commented 5 years ago

@VOD555 can you add to this PR please?

Possibly also add a test for more complicated return values of the tuple (something like (scalar, array) and (array, array) and (array,))

codecov[bot] commented 5 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files           8        8           
  Lines         497      497           
  Branches       70       70           
=======================================
  Hits          483      483           
  Misses          8        8           
  Partials        6        6
Impacted Files Coverage Δ
pmda/custom.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 83b381c...2a398e3. Read the comment docs.

VOD555 commented 5 years ago

All tests passed. Merge the pull request.