MDAnalysis / pmda

Parallel algorithms for MDAnalysis

https://www.mdanalysis.org/pmda/

Other

31 stars 22 forks source link

Add cdf function to InterRDF #99

Closed VOD555 closed 4 years ago

VOD555 commented 5 years ago

Changes made in this Pull Request:

Add cdf function to InterRDF

PR Checklist

[x] Tests?
[x] Docs?
[x] CHANGELOG updated?
[ ] Issue raised/referenced?

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3605ee8). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #99   +/-   ##
=========================================
  Coverage          ?   97.82%           
=========================================
  Files             ?       11           
  Lines             ?      644           
  Branches          ?       78           
=========================================
  Hits              ?      630           
  Misses            ?        8           
  Partials          ?        6

Impacted Files	Coverage Δ
pmda/leaflet.py	`91.3% <ø> (ø)`
pmda/rdf.py	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3605ee8...5d3716a. Read the comment docs.

orbeckst commented 5 years ago

(And please fix PEP8...)

orbeckst commented 5 years ago

Please also address the remaining comments.

VOD555 commented 5 years ago

@orbeckst All required changes have been done. Please have a look.