MDAnalysis / scipy_proceedings

SciPy conference proceedings: MDAnalysis paper
Other
0 stars 4 forks source link

Max changes #6

Closed kain88-de closed 8 years ago

kain88-de commented 8 years ago

Some small changes. I tried to keep every commit self contained. This should make it easy to delete changes that other don't agree on before it is merged.

The commit message contain a brief explanation for all changes

richardjgowers commented 8 years ago

I'd rather use line breaks for a reason rather than just 80? chars. I try and have each point in a sentence be a line (#9) which makes editing it easier.

kain88-de commented 8 years ago

We can also have a line for each paragraph.

I'm using emacs and vim only. Specifically vim movement commands work best with hard line breaks. Both understand the concept of a paragraph as text that isn't separated by a newline. So I tend to favor text with hard line breaks. I'm also OK with having one line per paragraph.

dotsdl commented 8 years ago

Can we do one line per sentence/independent clause? That makes diffs more meaningful, and gets those of us that use a text editor that relies on hard breaks for basic navigation (e.g. vim) what we need to function. :D

orbeckst commented 8 years ago

@kain88-de can we try @dotsdl 's suggestion #10 to use one line break per sentence? In my experience, hard line breaks after 79 col lead to fairly messy diffs (even though I still use it myself... mainly because I did not know about visual-line-mode in emacs...). #10 might be a decent compromise.

orbeckst commented 8 years ago

@kain88-de are you simply redoing the PR? (I was happy with the content.)

kain88-de commented 8 years ago

Yep I'm on the train home updates are coming later in the evening.