MDIL-SNU / SevenNet

SevenNet - a graph neural network interatomic potential package supporting efficient multi-GPU parallel molecular dynamics simulations.
https://pubs.acs.org/doi/10.1021/acs.jctc.4c00190
GNU General Public License v3.0
126 stars 14 forks source link

TODO list #86

Open YutackPark opened 1 month ago

YutackPark commented 1 month ago

TODO list

----------- on 'refactor' branch && v0.10.0 --------------

------------ Urgent -----------------

----------- Future -------------

thangckt commented 1 month ago

I suggest refactor the code to process dataset. It is too complicate, hard to read, making somebody lazy to contribute

thangckt commented 1 month ago

hi @YutackPark Are you consider to pure pyproject.toml ? I see many other project do not need setup.* files. I also recommand to use ruff as both linter & formatter, it demonstrates better performance over other ones.

YutackPark commented 1 month ago

Hi @thangckt

Are you consider to pure pyproject.toml ? I see many other project do not need setup.* files. Absolutely yes. But I left setup.py for editable mode when I first wrote project.toml. Because I wasn't able to install SevenNet with pip -e.

I also recommand to use ruff as both linter & formatter, it demonstrates better performance over other ones. Thanks for the recommendation. Maybe I could migrate to ruff with #98, and before github actions.