Open YutackPark opened 1 month ago
I suggest refactor the code to process dataset. It is too complicate, hard to read, making somebody lazy to contribute
hi @YutackPark
Are you consider to pure pyproject.toml
? I see many other project do not need setup.*
files.
I also recommand to use ruff
as both linter & formatter, it demonstrates better performance over other ones.
Hi @thangckt
Are you consider to pure pyproject.toml ? I see many other project do not need setup.* files. Absolutely yes. But I left
setup.py
for editable mode when I first wroteproject.toml
. Because I wasn't able to install SevenNet withpip -e
.I also recommand to use ruff as both linter & formatter, it demonstrates better performance over other ones. Thanks for the recommendation. Maybe I could migrate to
ruff
with #98, and before github actions.
TODO list
----------- on 'refactor' branch && v0.10.0 --------------
type_map
scripts/processing_dataset.py
andtrain/dataset.py
universal
keyword forchemical_species
keypair_e3gnn.cpp
pretrained_potentials
------------ Urgent -----------------
----------- Future -------------
torch.compile
tag
-wise weights (fromsturcture_list
or more) and loggingdataload.py
(node_features, pos, cell, cell_shift, num_atoms(?), per_atom_energy)