Resolve issues #11 and #12

MDSLKTR / pouch-vue

Pouchdb bindings for Vue.js

MIT License

90 stars 17 forks source link

Resolve issues #11 and #12 #13

Closed assemblethis closed 5 years ago

assemblethis commented 5 years ago

This pull request resolves issues #11 and #12. There are also four unit tests included to test the beforeCreate lifecycle hook using Jest. All were successful when I ran the tests.

Issue 11: Is installSelectorReplicationPlugin() still needed when there's the pouchdb-find plugin now? Issue 12: Reactive Pouch Database Property is null in data() but available on root-level this

Let me know what you think!

MDSLKTR commented 5 years ago

Once this is merged, i suppose a new npm release would be appropriate? Or do you have some additional PRs lining up?

assemblethis commented 5 years ago

Thanks for approving the changes. I have some additional PRs lined up, though they may not be substantial, just a few minor fixes to the code. I'm working on improving the TypeScript declaration files as well and putting together some typings for pouchdb-live-find on Definitely Typed. Folllowing that, I've got an initial rewrite in TypeScript of this plugin that I'll create a dev branch for here.