Feature: jScope improvements

MDSplus / mdsplus

The MDSplus data management system

https://mdsplus.org/

Other

75 stars 44 forks source link

Feature: jScope improvements #2774

Closed GabrieleManduchi closed 5 months ago

GabrieleManduchi commented 5 months ago

jScope improvements:

1) Allow using expressions also for signal labels 2) Allow defining a time window for the most recent samples in trend visualization (i.e. absolute times). This is configured by setting in xmin field :

WhoBrokeTheBuild commented 5 months ago

Hi Gabriele,

Before we can merge, I need you to make some fixes to the PR on GitHub:

Please add "Feature:" as a prefix to the PR title
Also, make sure that this prefix also appears as the commit title when you squash and merge, if you don't then the version won't bump properly
Please add some reviewers
Please add the appropriate labels, for this I would add "feature" and "tool/jScope"

Afterwards, we'll take a look, thanks!

GabrieleManduchi commented 5 months ago

Done, the Feature prefix should be also already present in the original commit comment

mwinkel-dev commented 5 months ago

Hi @GabrieleManduchi -- Thanks for making the changes that @WhoBrokeTheBuild requested.

Note though that the first commit (hash 8400cac) has a typo. It is titled, ture:jScope improvements. So when merging, double-check the default merge-commit message that GitHub creates.

Anyway, we'll review this PR later today.