search

MDU-PHL / bohra

A pipeline for bioinformatics analysis of bacterial genomes
GNU General Public License v3.0
18 stars 4 forks source link

Make tests suite #64

Closed kristyhoran closed 1 year ago

kristyhoran commented 1 year ago
Wytamma commented 1 year ago

The biggest thing I can see is that it looks like the tests/test data are nested within the package? I think it will download all the test data at install time? e.g. running pip install install https://github.com/MDU-PHL/bohra/archive/make_tests_suite.zip downloads 350MB of data. Or is that stripped out during the wheel building?

Typically you'd keep tests at the top level of the repo and run them as part of CI/during development. Including them as checks to confirm installation is also valid, but you should probably move the test data to the top directory so it's not packaged with the library (assuming that is happening) and only downloaded when requested.

kristyhoran commented 1 year ago

Thanks @Wytamma and @stroehleina I will make changes in another pull request